Changeset 1706:a0210843485e

Timestamp:

07/22/08 14:36:47 (5 weeks ago)

Author:

klai@…

Branch:

default

Message:

Do not run commands blindly. The return code and stderr (stdout) may be very useful. (from rik)

Files:

• src/Tycoon/Virtualization/XenResources.py (modified) (1 diff)

src/Tycoon/Virtualization/XenResources.py

@@ -31 +31 @@
     if log:
         INFO('doing ' + cmd)
-    os.system(cmd)
-    
+    cmd_out = os.tmpfile()
+    cmd_err = os.tmpfile()
+    cmd_ret = os.system("exec 1>&%d 2>&%d; %s" %
+                        (cmd_out.fileno(), cmd_err.fileno(), cmd))
+    cmd_out.seek(0)
+    cmd_err.seek(0)
+    if cmd_ret is not 0:
+        ERROR(("The command '%s' has finished with exit code %s.\n" +\
+               "stdout: %s\nstderr: %s") %
+               (cmd, cmd_ret, cmd_out.read(), cmd_err.read()))
+    cmd_out.close()
+    cmd_err.close()
+    return cmd_ret
+
 class XenCPU(CPU):
     """